Fix to PeriodicPadding to match pytorch circular padding #2435
+68
−272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As batch size is implicit, remove from docstring. Remove unused "name" kwarg in function.
fiedorowicz1
approved these changes
Apr 17, 2024
bvanessen
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found that the output of
lm.PeriodicPadding2Ddid not match the output oftorch.nn.functional.pad(*, mode="circular"). See below for figure comparing the original implementation - clearly the middle image is doing the equivalent ofmode = "replicate"padding (not periodic/circular). I modified the existing CI test to compare against the torch function (it previously compared against padding done using np.concatenate).I also made some modifications to the docstring.
Cheers,
Josh